From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [RFC v2 00/19] batman-adv: netlink restructuring, part 2 Date: Sat, 24 Nov 2018 10:29:55 +0100 Message-ID: <20181124092955.GA2511@nanopsycho.orion> References: <20181123161359.13342-1-sven@narfation.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jiri Pirko , b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org To: Sven Eckelmann Return-path: Content-Disposition: inline In-Reply-To: <20181123161359.13342-1-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org Fri, Nov 23, 2018 at 05:13:40PM CET, sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org wrote: >Hi, > >Jiri Pirko called the batman-adv configuration interface a while back "a >huge mistake" [1] and suggested genl as alternative. The first >reimplementation [2] (based on the team/devlink design) was rejected. This >second implementation is now using a nl80211-like design. The objects >which can now be modified/queried are: > >* mesh/soft-interface (BATADV_CMD_GET_MESH/BATADV_CMD_SET_MESH) >* slave/hard-interface (BATADV_CMD_GET_HARDIF/BATADV_CMD_SET_HARDIF) >* vlan (BATADV_CMD_GET_VLAN/BATADV_CMD_SET_VLAN) > >Such a set messages automatically triggers a *_SET_* "reply" via the config >multicast group. The same behavior was also added to the sysfs interface. > >Luckily, Jiri Pirko told us that he will have a look at patches. I would >also like to ask the other developers to check whether their configuration >values are represented correctly. And please also check whether the current >implementation might collide with some other features which you might have >in your pipeline. > >v2: >* rewrite everything in a more nl80211-like message/attribute format. > >Kind regards, > Sven This looks great. Nice job! Do you have a userspace app to communicate with this? Would be nice to play with it or at least to see examples of usage. Thanks!