From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joey Pabalinas Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb() Date: Mon, 26 Nov 2018 00:16:30 -1000 Message-ID: <20181126101630.rcl2futyxqg7ejpj@gmail.com> References: <20181126093234.GA18963@svurukal-linux.qualcomm.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cqq6n3lxxfxl6ein" Cc: netdev@vger.kernel.org, kapandey@codeaurora.org, chinagar@codeaurora.org, Joey Pabalinas To: Sharath Chandra Vurukala Return-path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:38148 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbeKZVKL (ORCPT ); Mon, 26 Nov 2018 16:10:11 -0500 Received: by mail-pl1-f196.google.com with SMTP id e5so13650160plb.5 for ; Mon, 26 Nov 2018 02:16:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181126093234.GA18963@svurukal-linux.qualcomm.com> Sender: netdev-owner@vger.kernel.org List-ID: --cqq6n3lxxfxl6ein Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 26, 2018 at 03:05:50PM +0530, Sharath Chandra Vurukala wrote: > when the tcp_retranmission_timer expires and tcp_retranmsit_skb is > called if the retranmsission fails due to local congestion, > backoff should not incremented. >=20 > tcp_retransmit_skb() returns non-zero negative value in some cases of > failure but the caller tcp_retransmission_timer() has a check for > failure which checks if the return value is greater than zero. > The check is corrected to check for non-zero value. >=20 > Change-Id: I494fed73b2e385216402c91e9558d5c2884add5b > Signed-off-by: Sharath Chandra Vurukala You are right, tcp_retransmit_skb() calls `int err =3D __tcp_retransmit_skb= ()` which returns non-zero on error. Reviewed-by: Joey Pabalinas --=20 Cheers, Joey Pabalinas --cqq6n3lxxfxl6ein Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlv7x/0ACgkQ2rGdfm9D tVJ/4w//YjYCA0qLglChDcM7D/lMJpTkZhU6djQ6/dScvHT8cS/5Zt9GggEFdk8K MNg5rKfoBfd1XJfKyTL25oiS678+yicm8Ga2nDzYyqzE8oBZUHGuV3iiZ472Ynlo 9LlelJhEtlev2WQSPIKRI0XwmlGpprg19SX+uGiC7sLmRRqwqf2WoHvVlEv25egu NJElYM1oP6yOq6J09FdVJ+rSoMHZw2ILlumiA5flTRgYq5OgGp/OzlzqkbqWP+pq 1vCpBagdsGMtDcpIYlFsm8S7KY1PN6vTnL0NMKTX06/mqPTXAu1vXyQiLM3kSKfW +Xx21pxEGjo09RHGWf9s5VAi/dpVefCNdjcCSuDVGs1K16QFaY4+LZUffe6I54t0 XCBKWWxpFM7x6EWlK6WcmBp9pjIWOTZuEhZmK67ankFTiOUjdrNVIKl7Vby/+UBm Pmg6AyzRRRDCeFTefI37lRfiwFoa+faKnHBX3ocL5Hpw2cwyTFHwHd32xvYbVcyB 1tfMJHwJVIFGKULerEjGlsB4Nb3GcMBRhJGi3f8Pt8t7Vb8pM6gpq1OKfUFWgm90 24uK+cf1uSE8+KmAdKk4nrfOPsPusJRRJHHwHhaKtHbihjnjM+SW3rUqvFzfWugX Q+HpscpaVTOSRcPjHXv97BPIdfrHWYaNcUJQsyrmZHQM1NrYNLA= =PzmE -----END PGP SIGNATURE----- --cqq6n3lxxfxl6ein--