From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: igor.russkikh@aquantia.com, nikita.danilov@aquantia.com,
yana.esina@aquantia.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: aquantia: return 'err' if set MPI_DEINIT state fails
Date: Tue, 27 Nov 2018 15:25:39 -0800 (PST) [thread overview]
Message-ID: <20181127.152539.1127313634090592618.davem@davemloft.net> (raw)
In-Reply-To: <20181124101641.7072-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 24 Nov 2018 18:16:41 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:260:7:
> warning: variable 'err' set but not used [-Wunused-but-set-variable]
>
> 'err' should be returned while set MPI_DEINIT state fails
> in hw_atl_utils_soft_reset.
>
> Fixes: cce96d1883da ("net: aquantia: Regression on reset with 1.x firmware")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
But this AQ_HW_STATE_FOR macro _MUST_ be fixed.
No macro should have invisible references to variables like this, and
that is exactly what leads to bugs like this. CPP macros written this
way make it impossible to properly audit code.
'err' should be an explicit argument given to this function instead of
how it works now.
next prev parent reply other threads:[~2018-11-27 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 10:16 [PATCH net-next] net: aquantia: return 'err' if set MPI_DEINIT state fails YueHaibing
2018-11-27 23:25 ` David Miller [this message]
2018-11-28 9:40 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127.152539.1127313634090592618.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=igor.russkikh@aquantia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikita.danilov@aquantia.com \
--cc=yana.esina@aquantia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).