From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: tcp: add correct check for tcp_retransmit_skb()
Date: Tue, 27 Nov 2018 16:15:42 -0800 (PST)
Message-ID: <20181127.161542.1008284702383009349.davem@davemloft.net>
References: <20181126093234.GA18963@svurukal-linux.qualcomm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, kapandey@codeaurora.org,
        chinagar@codeaurora.org
To: sharathv@codeaurora.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:46666 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726327AbeK1LPv (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Nov 2018 06:15:51 -0500
In-Reply-To: <20181126093234.GA18963@svurukal-linux.qualcomm.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Sharath Chandra Vurukala <sharathv@codeaurora.org>
Date: Mon, 26 Nov 2018 15:05:50 +0530

> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
> 
> tcp_retransmit_skb() returns non-zero negative value in some cases of
> failure but the caller tcp_retransmission_timer() has a check for
> failure which checks if the return value is greater than zero.
> The check is corrected to check for non-zero value.
> 
> Change-Id: I494fed73b2e385216402c91e9558d5c2884add5b

No changeids please.

> Signed-off-by: Sharath Chandra Vurukala <sharathv@codeaurora.org>

This patch doesn't apply cleanly to my net tree.