From: David Miller <davem@davemloft.net>
To: Bryan.Whitehead@microchip.com
Cc: netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v3 net] lan743x: fix return value for lan743x_tx_napi_poll
Date: Tue, 27 Nov 2018 16:30:12 -0800 (PST) [thread overview]
Message-ID: <20181127.163012.1100834728216176999.davem@davemloft.net> (raw)
In-Reply-To: <1543251897-19192-1-git-send-email-Bryan.Whitehead@microchip.com>
From: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Date: Mon, 26 Nov 2018 12:04:57 -0500
> The lan743x driver, when under heavy traffic load, has been noticed
> to sometimes hang, or cause a kernel panic.
>
> Debugging reveals that the TX napi poll routine was returning
> the wrong value, 'weight'. Most other drivers return 0.
> And call napi_complete, instead of napi_complete_done.
>
> Additionally when creating the tx napi poll routine.
> Changed netif_napi_add, to netif_tx_napi_add.
>
> Updates for v3:
> changed 'fixes' tag to match defined format
>
> Updates for v2:
> use napi_complete, instead of napi_complete_done in
> lan743x_tx_napi_poll
> use netif_tx_napi_add, instead of netif_napi_add for
> registration of tx napi poll routine
>
> fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-11-28 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:04 [PATCH v3 net] lan743x: fix return value for lan743x_tx_napi_poll Bryan Whitehead
2018-11-28 0:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127.163012.1100834728216176999.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).