From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v3 net] lan743x: fix return value for
 lan743x_tx_napi_poll
Date: Tue, 27 Nov 2018 16:30:12 -0800 (PST)
Message-ID: <20181127.163012.1100834728216176999.davem@davemloft.net>
References: <1543251897-19192-1-git-send-email-Bryan.Whitehead@microchip.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
To: Bryan.Whitehead@microchip.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:46916 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726418AbeK1L3w (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 28 Nov 2018 06:29:52 -0500
In-Reply-To: <1543251897-19192-1-git-send-email-Bryan.Whitehead@microchip.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Date: Mon, 26 Nov 2018 12:04:57 -0500

> The lan743x driver, when under heavy traffic load, has been noticed
> to sometimes hang, or cause a kernel panic.
> 
> Debugging reveals that the TX napi poll routine was returning
> the wrong value, 'weight'. Most other drivers return 0.
> And call napi_complete, instead of napi_complete_done.
> 
> Additionally when creating the tx napi poll routine.
> Changed netif_napi_add, to netif_tx_napi_add.
> 
> Updates for v3:
>     changed 'fixes' tag to match defined format
> 
> Updates for v2:
> use napi_complete, instead of napi_complete_done in
>     lan743x_tx_napi_poll
> use netif_tx_napi_add, instead of netif_napi_add for
>     registration of tx napi poll routine
> 
> fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
> Signed-off-by: Bryan Whitehead <Bryan.Whitehead@microchip.com>

Applied and queued up for -stable.