From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails Date: Tue, 27 Nov 2018 09:54:48 +0100 Message-ID: <20181127085448.GA29599@kroah.com> References: <20181126102422.24028-1-yuehaibing@huawei.com> <44edc27b-e679-24e8-aef1-fe5b7570f982@enneenne.com> <20181127073410.GA13965@kroah.com> <53ba0e4e-5848-e6cb-4abf-39db292ba7f3@enneenne.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: YueHaibing , davem@davemloft.net, richardcochran@gmail.com, sudipm.mukherjee@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Rodolfo Giometti Return-path: Content-Disposition: inline In-Reply-To: <53ba0e4e-5848-e6cb-4abf-39db292ba7f3@enneenne.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, Nov 27, 2018 at 09:36:38AM +0100, Rodolfo Giometti wrote: > On 27/11/2018 08:34, Greg KH wrote: > > On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: > > > On 26/11/2018 11:24, YueHaibing wrote: > > > > pps_register_source() has keeps error codes in a local variable, > > > > but it does not make use of the code. This patch let it return > > > > the errcode in case of failure. > > > > > > > > Suggested-by: Richard Cochran > > > > Signed-off-by: YueHaibing > > > > > > Acked-by: Rodolfo Giometti > > > > You are the maintainer of this file, shouldn't you be the one sending it > > off to Linus or putting it in your tree somewhere? > > This subsystem never had an official tree and in the past I simply acked the > code and patches was taken by you (or other maintainers) for inclusion... I > know it's not usual by it worked as is since right now! > > However if you prefer having an official tree even for LinuxPPS I can do it > and then sending my pull requests to Linus! Just let me know what is better > for you! :-) Ok, I'll take it now, thanks. greg k-h