From: PanBian <bianpan2016@163.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Ilya Dryomov <idryomov@gmail.com>, "Yan, Zheng" <zyan@redhat.com>,
Sage Weil <sage@redhat.com>,
DavidS.Miller@bp, ceph-devel@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libceph: fix use after free
Date: Tue, 27 Nov 2018 17:09:52 +0800 [thread overview]
Message-ID: <20181127090952.GA23643@bp> (raw)
In-Reply-To: <54c1bcc5-6df5-ba24-2774-98f6333c57b3@cogentembedded.com>
On Tue, Nov 27, 2018 at 11:47:56AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 27.11.2018 10:02, Pan Bian wrote:
>
> >The function ceph_monc_handle_map calls kfree(old) to free the old
> >monitor map, old points to monc->monmap. However, after that, it reads
> >monc->monmap->epoch and passes it to __ceph_monc_got_map. This result in
> >a use-after-free bug. The patch moves the free operation after the call
> >to __ceph_monc_got_map.
> >
> >Fixes: 82dcabad750("libceph: revamp subs code, switch to SUBSCRIBE2
>
> Space needed before (.
>
> >protocol")
>
> Never break up the commit summary in this tag.
Thanks for the guidance, I will correct it.
>
> >Signed-off-by: Pan Bian <bianpan2016@163.com>
> [...]
>
> MBR, Sergei
prev parent reply other threads:[~2018-11-27 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 7:02 [PATCH] libceph: fix use after free Pan Bian
2018-11-27 8:47 ` Sergei Shtylyov
2018-11-27 9:09 ` PanBian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127090952.GA23643@bp \
--to=bianpan2016@163.com \
--cc=DavidS.Miller@bp \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sage@redhat.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).