From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] be2net: Fix NULL pointer dereference in
 be_tx_timeout()
Date: Wed, 28 Nov 2018 11:00:20 -0800 (PST)
Message-ID: <20181128.110020.1466319069502491864.davem@davemloft.net>
References: <20181122142407.18304-1-poros@redhat.com>
        <20181127.145108.1921689913131989867.davem@davemloft.net>
        <932ae382-a1fe-c7ad-a9b3-e728ed6c1176@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: poros@redhat.com, netdev@vger.kernel.org
To: ivecera@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:36408 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725772AbeK2GC6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Nov 2018 01:02:58 -0500
In-Reply-To: <932ae382-a1fe-c7ad-a9b3-e728ed6c1176@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ivan Vecera <ivecera@redhat.com>
Date: Wed, 28 Nov 2018 11:12:22 +0100

> On 27. 11. 18 23:51, David Miller wrote:
>> From: Petr Oros <poros@redhat.com>
>> Date: Thu, 22 Nov 2018 15:24:07 +0100
>> 
>>> @@ -4700,8 +4700,11 @@ int be_update_queues(struct be_adapter
>>> *adapter)
>>>   	struct net_device *netdev = adapter->netdev;
>>>   	int status;
>>>   -	if (netif_running(netdev))
>>> +	if (netif_running(netdev)) {
>>> +		/* prevent netdev watchdog during tx queue destroy */
>>> +		netif_carrier_off(netdev);
>>>   		be_close(netdev);
>>> +	}
>> This will make userspace networking daemons will think that the link
>> went down.
>> This absolutely should not be a side effect of making a simple
>> TX queue configuration change via ethtool.
>> 
> 
> Yes, you're right Dave. But the same thing (netif_carrier_off()) is
> done by number of other drivers (igb, tg3, ixgbe...) during
> .set_channels() callback. The patch that Petr sent does the
> practically the same thing like this one:

Bug exist in other drivers, thanks for reporting that.

It doesn't mean you should add the same bug here as well.