* [PATCH net-next] net: neterion: vxge: remove set but not used variables 'max_frags' and 'txdl_priv'
@ 2018-11-28 12:24 YueHaibing
2018-11-28 19:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-11-28 12:24 UTC (permalink / raw)
To: davem, jdmason, natechancellor, clabbe; +Cc: linux-kernel, netdev, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/neterion/vxge/vxge-traffic.c:1698:35:
warning: variable 'txdl_priv' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/neterion/vxge/vxge-traffic.c:1699:6:
warning: variable 'max_frags' set but not used [-Wunused-but-set-variable]
It never used since introduction in
commit 113241321dcd ("Neterion: New driver: Traffic & alarm handler")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/neterion/vxge/vxge-traffic.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
index f7a0d1d..59e77e30 100644
--- a/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
+++ b/drivers/net/ethernet/neterion/vxge/vxge-traffic.c
@@ -1695,17 +1695,10 @@ enum vxge_hw_status vxge_hw_fifo_handle_tcode(struct __vxge_hw_fifo *fifo,
*/
void vxge_hw_fifo_txdl_free(struct __vxge_hw_fifo *fifo, void *txdlh)
{
- struct __vxge_hw_fifo_txdl_priv *txdl_priv;
- u32 max_frags;
struct __vxge_hw_channel *channel;
channel = &fifo->channel;
- txdl_priv = __vxge_hw_fifo_txdl_priv(fifo,
- (struct vxge_hw_fifo_txd *)txdlh);
-
- max_frags = fifo->config->max_frags;
-
vxge_hw_channel_dtr_free(channel, txdlh);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: neterion: vxge: remove set but not used variables 'max_frags' and 'txdl_priv'
2018-11-28 12:24 [PATCH net-next] net: neterion: vxge: remove set but not used variables 'max_frags' and 'txdl_priv' YueHaibing
@ 2018-11-28 19:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-11-28 19:10 UTC (permalink / raw)
To: yuehaibing; +Cc: jdmason, natechancellor, clabbe, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 28 Nov 2018 20:24:41 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/neterion/vxge/vxge-traffic.c:1698:35:
> warning: variable 'txdl_priv' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/neterion/vxge/vxge-traffic.c:1699:6:
> warning: variable 'max_frags' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> commit 113241321dcd ("Neterion: New driver: Traffic & alarm handler")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-28 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-28 12:24 [PATCH net-next] net: neterion: vxge: remove set but not used variables 'max_frags' and 'txdl_priv' YueHaibing
2018-11-28 19:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).