From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, julien@cumulusnetworks.com
Subject: Re: [PATCH iproute2] bridge: make -c match -compressvlans first instead of -color
Date: Wed, 28 Nov 2018 16:01:30 -0800 [thread overview]
Message-ID: <20181128160130.2b9349dc@xeon-e3> (raw)
In-Reply-To: <1543370572-19373-1-git-send-email-roopa@cumulusnetworks.com>
On Tue, 27 Nov 2018 18:02:52 -0800
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> broke previous use of -c to represent compressvlans. This restores
> previous use of -c to represent compressvlans. Understand the original
> motivation to use -c to represent color consistently everywhere but
> there are apps and network interface managers out there that are already
> using -c to prepresent compressed vlans.
>
> Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied.
prev parent reply other threads:[~2018-11-29 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 2:02 [PATCH iproute2] bridge: make -c match -compressvlans first instead of -color Roopa Prabhu
2018-11-28 18:11 ` David Ahern
2018-11-29 0:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128160130.2b9349dc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsa@cumulusnetworks.com \
--cc=julien@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).