From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH RFC iproute2-next 1/2] rdma: add 'link add/delete' commands Date: Wed, 28 Nov 2018 15:17:11 -0700 Message-ID: <20181128221711.GH19914@ziepe.ca> References: <7026be07534b14fd74e592c315523c57fde05a0a.1543422310.git.swise@opengridcomputing.com> <20181128182645.GJ4559@mtr-leonro.mtl.com> <20181128200412.GP4559@mtr-leonro.mtl.com> <20181128201303.GR4559@mtr-leonro.mtl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Leon Romanovsky , dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, BMT@zurich.ibm.com To: Steve Wise Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:33100 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbeK2JUW (ORCPT ); Thu, 29 Nov 2018 04:20:22 -0500 Received: by mail-pl1-f194.google.com with SMTP id z23so18067194plo.0 for ; Wed, 28 Nov 2018 14:17:14 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Nov 28, 2018 at 02:18:55PM -0600, Steve Wise wrote: > > > On 11/28/2018 2:13 PM, Leon Romanovsky wrote: > > On Wed, Nov 28, 2018 at 02:07:29PM -0600, Steve Wise wrote: > >> > >> On 11/28/2018 2:04 PM, Leon Romanovsky wrote: > >>> On Wed, Nov 28, 2018 at 01:08:05PM -0600, Steve Wise wrote: > >>>> On 11/28/2018 12:26 PM, Leon Romanovsky wrote: > >>>>> On Thu, Sep 13, 2018 at 10:19:21AM -0700, Steve Wise wrote: > >>>>>> Add new 'link' subcommand 'add' and 'delete' to allow binding a soft-rdma > >>>>>> device to a netdev interface. > >>>>>> > >>>>>> EG: > >>>>>> > >>>>>> rdma link add rxe_eth0 type rxe dev eth0 > >>>>>> rdma link delete rxe_eth0 > >>>>>> > >>>>>> Signed-off-by: Steve Wise > >>>>>> rdma/link.c | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > >>>>>> rdma/rdma.h | 1 + > >>>>>> rdma/utils.c | 2 +- > >>>>>> 3 files changed, 108 insertions(+), 1 deletion(-) > >>>>>> > >>>>>> diff --git a/rdma/link.c b/rdma/link.c > >>>>>> index 7a6d4b7e356d..d4f76b0ce11f 100644 > >>>>>> +++ b/rdma/link.c > >>>>>> @@ -14,6 +14,8 @@ > >>>>>> static int link_help(struct rd *rd) > >>>>>> { > >>>>>> pr_out("Usage: %s link show [DEV/PORT_INDEX]\n", rd->filename); > >>>>>> + pr_out("Usage: %s link add NAME type TYPE dev DEV\n", rd->filename); > >>>>> I suggest to rename "dev" to be "netdev", because we are using "dev" for > >>>>> ib devices. > >>>> Yea ok. > >>>> > >>>>>> + pr_out("Usage: %s link delete NAME type TYPE\n", rd->filename); > >>>>> Why do you need "type" for "delete" command? > >>>> Because the type is used in the kernel to find the appropriate link > >>>> ops.  I could change the kernel side to search all types for the device > >>>> name to delete?  > >>> I would say, yes. > >>> It makes "delete" operation more natural. > >>> > >>> Thanks > >> Perhaps. > >> > >> Note: 'ip link delete' takes a type as well... > > According to man section, yes. > > According to various guides, no. > > https://docs.fedoraproject.org/en-US/Fedora/20/html/Networking_Guide/sec-Configure_802_1Q_VLAN_Tagging_ip_Commands.html > > > > Thanks > > It does make sense to not require type.  The name must be unique so that > should be enough.  I'll have to respin the kernel side though... The delete_link really should be an operation on the ib_device, not the link_ops thing. That directly prevents mis-matching function callbacks.. Jason