From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net] net: dsa: Fix tagging attribute location Date: Thu, 29 Nov 2018 02:06:59 +0100 Message-ID: <20181129010659.GD5037@lunn.ch> References: <20181128214012.16397-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Vivien Didelot , "David S. Miller" , open list To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: <20181128214012.16397-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, Nov 28, 2018 at 01:40:04PM -0800, Florian Fainelli wrote: > While introducing the DSA tagging protocol attribute, it was added to the DSA > slave network devices, but those actually see untagged traffic (that is their > whole purpose). Correct this mistake by putting the tagging sysfs attribute > under the DSA master network device where this is the information that we need. > > While at it, also correct the sysfs documentation mistake that missed the > "dsa/" directory component of the attribute. > > Fixes: 98cdb4807123 ("net: dsa: Expose tagging protocol to user-space") > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew