From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in
 aqc111_suspend
Date: Wed, 28 Nov 2018 22:54:40 -0700
Message-ID: <20181129055440.GA2882@flashbox>
References: <20181129051808.30015-1-natechancellor@gmail.com>
 <20181128.215241.702406654469517539.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dmitry.bezrukov@aquantia.com, igor.russkikh@aquantia.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20181128.215241.702406654469517539.davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Wed, 28 Nov 2018 22:18:09 -0700
> 
> > Clang warns:
> > 
> > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> > initialization of subobject [-Wmissing-braces]
> >                 struct aqc111_wol_cfg wol_cfg = { 0 };
> >                                                   ^
> >                                                   {}
> > 1 warning generated.
> > 
> > Add another set of braces to initialize the char subobjects as well.
> > 
> > Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> This will in turn make some versions of gcc warn.
> 
> Please just memset() this object, thanks.

I thought this was the form that all compilers seemed to agree on but
sure, I will send a v2.

Thanks for the quick response,
Nathan