From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf-next v2] tools/bpf: make libbpf _GNU_SOURCE friendly Date: Thu, 29 Nov 2018 15:47:31 -0800 Message-ID: <20181129154731.4e5c0f9f@cakuba.netronome.com> References: <20181129233145.2100451-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: , , , To: Yonghong Song Return-path: Received: from mail-qt1-f196.google.com ([209.85.160.196]:46615 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726406AbeK3Kyw (ORCPT ); Fri, 30 Nov 2018 05:54:52 -0500 Received: by mail-qt1-f196.google.com with SMTP id y20so4050232qtm.13 for ; Thu, 29 Nov 2018 15:47:36 -0800 (PST) In-Reply-To: <20181129233145.2100451-1-yhs@fb.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 29 Nov 2018 15:31:45 -0800, Yonghong Song wrote: > During porting libbpf to bcc, I got some warnings like below: > ... > [ 2%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/li= bbpf.c.o > /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf.c:12:0: > warning: "_GNU_SOURCE" redefined [enabled by default] > #define _GNU_SOURCE > ... > [ 3%] Building C object src/cc/CMakeFiles/bpf-shared.dir/libbpf/src/li= bbpf_errno.c.o > /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf_errno.c: In function =E2= =80=98libbpf_strerror=E2=80=99: > /home/yhs/work/bcc2/src/cc/libbpf/src/libbpf_errno.c:45:7: > warning: assignment makes integer from pointer without a cast [enabled = by default] > ret =3D strerror_r(err, buf, size); > ... >=20 > bcc is built with _GNU_SOURCE defined and this caused the above warning. > This patch intends to make libpf _GNU_SOURCE friendly by > . define _GNU_SOURCE in libbpf.c unless it is not defined > . undefine _GNU_SOURCE as non-gnu version of strerror_r is expected. >=20 > Signed-off-by: Yonghong Song Acked-by: Jakub Kicinski FWIW :)