From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper
 func
Date: Thu, 29 Nov 2018 16:55:44 +0100
Message-ID: <20181129155544.GB31740@bistromath.localdomain>
References: <1543444079-29883-1-git-send-email-roopa@cumulusnetworks.com>
 <1543444079-29883-4-git-send-email-roopa@cumulusnetworks.com>
 <20181129141936.GB20478@bistromath.localdomain>
 <CAJieiUiONZiO0vyDzJpAiQK-hg2nU93qCvx0Tcgvbz=7e=e1_w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:8488 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728363AbeK3DBg (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 29 Nov 2018 22:01:36 -0500
Content-Disposition: inline
In-Reply-To: <CAJieiUiONZiO0vyDzJpAiQK-hg2nU93qCvx0Tcgvbz=7e=e1_w@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

2018-11-29, 07:27:17 -0800, Roopa Prabhu wrote:
> On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca <sd@queasysnail.net> wrote:
> > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote:
> > nit: This patch would have been easier to review if it came first in
> > the series. Converting:
> 
> I considered that. But the first patch really removes some checks
> making it easier for the follow-on patches...and that mostly dictated
> the order.

ok.

> >     if (nla_get_u8(data[IFLA_VXLAN_FOO]))
> >         conf->flags |= VXLAN_F_FOO;
> >
> > to this new helper, which in effect does
> >
> >     if (nla_get_u8(data[IFLA_VXLAN_FOO]))
> >         conf->flags |= VXLAN_F_FOO;
> >     else
> >         conf->flags &= ~VXLAN_F_FOO;
> >
> > seems to change behavior, but since you're (unless I missed one) only
> > applying it to flags that couldn't be changed before patch 1, it looks
> > fine.
> 
> It does not change behavior...the earlier code only supported the
> flags during create time and did not support changing of the flag with
> changelink.
> this patch adds changelink support. But if you do see any change in
> behavior, pls report. thanks.

Yeah, looks correct. I just had to go back to patch 1 and check.
A note "only flags [list] are changed, and they could not be modified
after creation of the device prior to patch 1" in the cover and/or in
this patch's commit message would have spared reviewers a bit of a
scare :)

-- 
Sabrina