From: David Miller <davem@davemloft.net>
To: alexei.starovoitov@gmail.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org, ast@kernel.org,
john.fastabend@gmail.com
Subject: Re: BPF uapi structures and 32-bit
Date: Fri, 30 Nov 2018 16:58:47 -0800 (PST) [thread overview]
Message-ID: <20181130.165847.730597502210140882.davem@davemloft.net> (raw)
In-Reply-To: <20181130233307.kue2so72mga6z6qg@ast-mbp.dhcp.thefacebook.com>
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date: Fri, 30 Nov 2018 15:33:08 -0800
> On Wed, Nov 28, 2018 at 11:02:00AM -0800, David Miller wrote:
>> From: Daniel Borkmann <daniel@iogearbox.net>
>> Date: Wed, 28 Nov 2018 11:34:55 +0100
>>
>> > Yeah fully agree. Thinking diff below should address it, do you
>> > have a chance to give this a spin for sparc / 32 bit to check if
>> > test_verifier still explodes?
>>
>> Great, let me play with this.
>>
>> I did something simpler yesterday, just changing the data pointers to
>> "u64" and that made at least one test pass that didn't before :-)
>>
>> I'll get back to you with results.
>
> Did you have a chance to test it ?
>
> I'd like to add a tested-by before I apply Daniel's patch
> which looks good to me. btw.
Tested-by: David S. Miller <davem@davemloft.net>
Yes, it does the trick.
prev parent reply other threads:[~2018-12-01 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 22:25 BPF uapi structures and 32-bit David Miller
2018-11-28 10:34 ` Daniel Borkmann
2018-11-28 19:02 ` David Miller
2018-11-30 23:33 ` Alexei Starovoitov
2018-11-30 23:53 ` Daniel Borkmann
2018-12-01 0:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130.165847.730597502210140882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).