From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: BPF uapi structures and 32-bit Date: Fri, 30 Nov 2018 16:58:47 -0800 (PST) Message-ID: <20181130.165847.730597502210140882.davem@davemloft.net> References: <6ce1df16-6bcd-fb0a-f7fb-8dee45916438@iogearbox.net> <20181128.110200.1264664274998624358.davem@davemloft.net> <20181130233307.kue2so72mga6z6qg@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, netdev@vger.kernel.org, ast@kernel.org, john.fastabend@gmail.com To: alexei.starovoitov@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:36496 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbeLAMKD (ORCPT ); Sat, 1 Dec 2018 07:10:03 -0500 In-Reply-To: <20181130233307.kue2so72mga6z6qg@ast-mbp.dhcp.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Alexei Starovoitov Date: Fri, 30 Nov 2018 15:33:08 -0800 > On Wed, Nov 28, 2018 at 11:02:00AM -0800, David Miller wrote: >> From: Daniel Borkmann >> Date: Wed, 28 Nov 2018 11:34:55 +0100 >> >> > Yeah fully agree. Thinking diff below should address it, do you >> > have a chance to give this a spin for sparc / 32 bit to check if >> > test_verifier still explodes? >> >> Great, let me play with this. >> >> I did something simpler yesterday, just changing the data pointers to >> "u64" and that made at least one test pass that didn't before :-) >> >> I'll get back to you with results. > > Did you have a chance to test it ? > > I'd like to add a tested-by before I apply Daniel's patch > which looks good to me. btw. Tested-by: David S. Miller Yes, it does the trick.