netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gerg@kernel.org
To: sean.wang@mediatek.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org
Cc: blogic@openwrt.org, neil@brown.name
Subject: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC
Date: Fri, 30 Nov 2018 17:57:34 +1000	[thread overview]
Message-ID: <20181130075737.8041-1-gerg@kernel.org> (raw)

I have been working towards supporting the MT7530 switch as used in the
MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621 is built around
a dual core MIPS CPU architecture. But underneath it is what appears to
be the same 7530 switch.

The following 3 patches are more of an RFC than anything. They allow
use of the mt7530 dsa driver on this device - though with some issues
still to resolve. The primary change required is to not use the 7623
specific clock and regulator setup - none of that applies when using
the 7621 (and maybe other devices?). The other change required is to
set the 7530 MFC register CPU port number and enable bit.

The unresolved issues I still have appear to be more related to the
MT7621 ethernet driver (drivers/staging/mt7621-eth/*). I am hoping
someone might have some ideas on these. I don't really have any good
documentation on the ethernet devices on the 7621, so I am kind of
working in the dark here.

1. TX packets are not getting an IP header checksum via the normal
   off-loaded checksumming when in DSA mode. I have to switch off
   NETIF_F_IP_CSUM, so the software stack generates the checksum.
   That checksum offloading works ok when not using the 7530 DSA driver.

2. Maximal sized RX packets get silently dropped. So receive side packets
   that are large (perfect case is the all-but-last packets in a fragemented
   larger packet) appear to be dropped at the mt7621 ethernet MAC level.
   The 7530 MIB switch register counters show receive packets at the physical
   switch port side and at the CPU switch port - but I get no packets
   received or errors in the 7621 ethernet MAC. If I set the mtu of the
   server at the other end a little smaller (a few bytes is enough) then
   I get all the packets through. It seems like the DSA/VLAN tag bytes
   are causing a too large packet to get silently dropped somewhere.

Any thoughts greatly appreciated...

 Documentation/devicetree/bindings/net/dsa/mt7530.txt |    5 +
 drivers/net/dsa/mt7530.c                             |   95 ++++++++++++-------
 drivers/net/dsa/mt7530.h                             |    5 +
 3 files changed, 70 insertions(+), 35 deletions(-)

             reply	other threads:[~2018-11-30 19:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  7:57 gerg [this message]
2018-11-30  7:57 ` [PATCH 1/3] net: dsa: mt7530: make clock/regulator setup optional gerg
2018-11-30  7:57 ` [PATCH 2/3] net: dsa: mt7530: optional setting CPU field in MFC register gerg
2018-11-30  7:57 ` [PATCH 3/3] dt-bindings: net: dsa: add new bindings MT7530 gerg
2018-11-30 17:41   ` Florian Fainelli
2018-12-03  7:03     ` Greg Ungerer
2018-12-03 13:19       ` Andrew Lunn
2018-11-30 11:27 ` [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC René van Dorst
2018-11-30 13:25   ` Greg Ungerer
2018-11-30 11:30 ` René van Dorst
2018-11-30 12:16 ` Bjørn Mork
2018-11-30 13:41   ` Greg Ungerer
2018-11-30 13:42   ` Andrew Lunn
2018-12-03  7:20   ` Greg Ungerer
2018-12-03 11:34     ` Bjørn Mork
2018-12-03 14:00       ` René van Dorst
2018-12-03 14:02         ` John Crispin
2018-12-07  7:12           ` Greg Ungerer
2018-12-04  7:23       ` Greg Ungerer
2018-12-11  5:02   ` NeilBrown
2018-12-11  8:28     ` Bjørn Mork
2018-12-16 22:08     ` NeilBrown
2018-12-16 22:14       ` David Miller
2018-12-16 23:19         ` NeilBrown
2018-12-17  0:00           ` Florian Fainelli
2018-12-17  7:11             ` NeilBrown
2018-11-30 13:33 ` Andrew Lunn
2018-12-03  6:47   ` Greg Ungerer
2018-11-30 13:37 ` Andrew Lunn
2018-11-30 13:45   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130075737.8041-1-gerg@kernel.org \
    --to=gerg@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=blogic@openwrt.org \
    --cc=f.fainelli@gmail.com \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).