From: Christoph Hellwig <hch@lst.de>
To: Qian Cai <cai@gmx.us>
Cc: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
iommu@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-debug: hns_enet_drv could use more DMA entries
Date: Fri, 30 Nov 2018 09:42:03 +0100 [thread overview]
Message-ID: <20181130084203.GA19812@lst.de> (raw)
In-Reply-To: <20181130035456.1586-1-cai@gmx.us>
On Thu, Nov 29, 2018 at 10:54:56PM -0500, Qian Cai wrote:
> /* allow architectures to override this if absolutely required */
> #ifndef PREALLOC_DMA_DEBUG_ENTRIES
> +/* amount of DMA mappings on this driver is huge. */
> +#ifdef HNS_ENET
> +#define PREALLOC_DMA_DEBUG_ENTRIES (1 << 17)
> +#else
> #define PREALLOC_DMA_DEBUG_ENTRIES (1 << 16)
> #endif
> +#endif
How would this be defined in a header that leaks into this file?
I think we need to turn PREALLOC_DMA_DEBUG_ENTRIES into a user
selectable config options, as I really don't want to collect hacks like
this.
next prev parent reply other threads:[~2018-11-30 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 3:54 [PATCH] dma-debug: hns_enet_drv could use more DMA entries Qian Cai
2018-11-30 8:42 ` Christoph Hellwig [this message]
[not found] ` <20181130084203.GA19812-jcswGhMUV9g@public.gmane.org>
2018-11-30 9:16 ` John Garry
2018-11-30 12:04 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130084203.GA19812@lst.de \
--to=hch@lst.de \
--cc=cai@gmx.us \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).