From: Andrew Lunn <andrew@lunn.ch>
To: Steve Douthit <stephend@silicom-usa.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] ixgbe: register a mdiobus
Date: Fri, 30 Nov 2018 17:34:37 +0100 [thread overview]
Message-ID: <20181130163437.GF25553@lunn.ch> (raw)
In-Reply-To: <ae364876-d63d-e3f4-71aa-ad81ab0114f1@silicom-usa.com>
> Yep, registering multiple interfaces is wrong. The first board I tested
> against only had a single MAC enabled (they can be disabled/hidden via
> straps) so it just happened to work.
Hi Steve
Can you hide any/all via straps, or is 00.0 always guaranteed to
exist?
> The Intel C3xxx family of SoCs have up to four ixgbe MACs. These are
> structured as two devices of two functions each on fixed internal root
> ports.
>
> from lspci:
> <snip>
> +-16.0-[05]--+-00.0
> | \-00.1
> +-17.0-[06]--+-00.0
> | \-00.1
> <snip>
Is there any other hardware resource which is shared between the MAC
interfaces? I'm just wondering if the driver has already solved this
once. Is there an EEPROM per interface for the MAC address, or one
shared EEPROM?
Ah, how about using the 'cards_found' found variable. It is not
perfect, in that it is not decremented in ixgb_remove(), and i wonder
about race conditions since there does not appear to be any lock when
it is incremented. But if cards_found == 0, register the MDIO bus.
Andrew
next prev parent reply other threads:[~2018-12-01 3:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 18:54 [PATCH net-next 0/2] Add mii_bus to ixgbe driver for dsa devs Steve Douthit
2018-11-29 18:54 ` [PATCH net-next 1/2] ixgbe: register a mdiobus Steve Douthit
2018-11-30 13:21 ` Andrew Lunn
2018-11-30 15:22 ` Steve Douthit
2018-11-30 16:34 ` Andrew Lunn [this message]
2018-11-30 17:34 ` Steve Douthit
2018-11-30 17:43 ` Florian Fainelli
2018-11-30 18:43 ` Steve Douthit
2018-11-30 19:20 ` Andrew Lunn
2018-11-29 18:54 ` [PATCH net-next 2/2] ixgbe: use mii_bus to handle MII related ioctls Steve Douthit
2018-11-29 19:03 ` [PATCH net-next 0/2] Add mii_bus to ixgbe driver for dsa devs Jeff Kirsher
2018-11-29 22:19 ` Steve Douthit
2018-11-29 22:54 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130163437.GF25553@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stephend@silicom-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).