From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net] rtnetlink: Refine sanity checks in rtnl_fdb_{add|del}
Date: Fri, 30 Nov 2018 19:00:24 +0200
Message-ID: <20181130170024.GA24630@splinter.mtl.com>
References: <20181130133501.62251-1-edumazet@google.com>
 <20181130145832.GA18412@splinter.mtl.com>
 <CANn89iJE3Tfv1UMw_u0OP8hFs4mVu7=KqW0+5OWA2gA7x7e6pw@mail.gmail.com>
 <31f441a7-9bc8-b087-26ce-5e7c1910b388@gmail.com>
 <20181130160208.GB22321@splinter.mtl.com>
 <CACT4Y+aGZy6vw2ysNwTuBOOTyagRDz-MuYrz2DVkjzs7DuQGCA@mail.gmail.com>
 <CANn89iKm=WookfR6X8u46781czOyQXka3pvfdGwiUTtJrGE_uw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Dmitry Vyukov <dvyukov@google.com>,
        David Ahern <dsahern@gmail.com>,
        David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        syzkaller@googlegroups.com, idosch@mellanox.com
To: Eric Dumazet <edumazet@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36239 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726659AbeLAEKZ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 30 Nov 2018 23:10:25 -0500
Content-Disposition: inline
In-Reply-To: <CANn89iKm=WookfR6X8u46781czOyQXka3pvfdGwiUTtJrGE_uw@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Nov 30, 2018 at 08:17:04AM -0800, Eric Dumazet wrote:
> On Fri, Nov 30, 2018 at 8:10 AM Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> > On Fri, Nov 30, 2018 at 4:02 PM, Ido Schimmel <idosch@idosch.org> wrote:
> > > On Fri, Nov 30, 2018 at 08:59:09AM -0700, David Ahern wrote:
> > >> This does not repro for me:
> > >> # ./a.out
> > >> Invalid address length 6 - must be 4 bytes
> > >> RTNETLINK answers: No buffer space available
> > >> RTNETLINK answers: Operation not supported
> > >> Invalid address length 6 - must be 4 bytes
> > >> Invalid address length 6 - must be 4 bytes
> > >> Invalid address length 6 - must be 4 bytes
> > >> Invalid address length 6 - must be 16 bytes
> > >> Invalid address length 6 - must be 16 bytes
> > >> Invalid address length 6 - must be 16 bytes
> > >>
> > >> config available>?
> > >
> > > You need a kernel with kmsan. See:
> > > https://github.com/google/kmsan
> >
> >
> > Another option may be to spray memory at the allocation stack with
> > some distinctive byte pattern and then check this pattern at the use
> > stack. Not 100% sounds, but should be enough for testing.
> 
> Well, no need for kmsan here, once you know the problem

Yes, agree. Patch is good. I'll tag your v2.

Thanks!