From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sharath Chandra Vurukala Subject: [PATCH] net: tcp: add correct check for tcp_retransmit_skb() Date: Fri, 30 Nov 2018 23:58:38 +0530 Message-ID: <20181130182828.GA27508@svurukal-linux.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: chinagar@codeaurora.org, kapandey@codeaurora.org, subashab@codeaurora.org To: netdev@vger.kernel.org Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:45162 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbeLAFi6 (ORCPT ); Sat, 1 Dec 2018 00:38:58 -0500 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: when the tcp_retranmission_timer expires and tcp_retranmsit_skb is called if the retranmsission fails due to local congestion, backoff should not incremented. tcp_retransmit_skb() returns non-zero negative value in some cases of failure but the caller tcp_retransmission_timer() has a check for failure which checks if the return value is greater than zero. The check is corrected to check for non-zero value. Signed-off-by: Sharath Chandra Vurukala --- net/ipv4/tcp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index 091c5392..c19f371 100644 --- a/net/ipv4/tcp_timer.c +++ b/net/ipv4/tcp_timer.c @@ -511,7 +511,7 @@ void tcp_retransmit_timer(struct sock *sk) tcp_enter_loss(sk); - if (tcp_retransmit_skb(sk, tcp_rtx_queue_head(sk), 1) > 0) { + if (tcp_retransmit_skb(sk, tcp_rtx_queue_head(sk), 1) != 0) { /* Retransmission failed because of local congestion, * do not backoff. */ -- 1.9.1