From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, pabeni@redhat.com,
Willem de Bruijn <willemb@google.com>
Subject: [PATCH net-next v4 0/3] udp msg_zerocopy
Date: Fri, 30 Nov 2018 15:32:38 -0500 [thread overview]
Message-ID: <20181130203241.205490-1-willemdebruijn.kernel@gmail.com> (raw)
From: Willem de Bruijn <willemb@google.com>
Enable MSG_ZEROCOPY for udp sockets
Patch 1/3 is the main patch, a rework of RFC patch
http://patchwork.ozlabs.org/patch/899630/
more details in the patch commit message
Patch 2/3 is an optimization to remove a branch from the UDP hot path
and refcount_inc/refcount_dec_and_test pair when zerocopy is used.
This used to be included in the first patch in v2.
Patch 3/3 runs the already existing udp zerocopy tests
as part of kselftest
See also recent Linux Plumbers presentation
https://linuxplumbersconf.org/event/2/contributions/106/attachments/104/128/willemdebruijn-lpc2018-udpgso-presentation-20181113.pdf
Changes:
v1 -> v2
- Fixup reverse christmas tree violation
v2 -> v3
- Split refcount avoidance optimization into separate patch
- Fix refcount leak on error in fragmented case
(thanks to Paolo Abeni for pointing this one out!)
- Fix refcount inc on zero
v3 -> v4
- Move skb_zcopy_set below the only kfree_skb that might cause
a premature uarg destroy before skb_zerocopy_put_abort
- Move the entire skb_shinfo assignment block, to keep that
cacheline access in one place
Willem de Bruijn (3):
udp: msg_zerocopy
udp: elide zerocopy operation in hot path
selftests: extend zerocopy tests to udp
include/linux/skbuff.h | 13 +++++---
net/core/skbuff.c | 15 ++++++---
net/core/sock.c | 5 ++-
net/ipv4/ip_output.c | 37 ++++++++++++++++-----
net/ipv4/tcp.c | 2 +-
net/ipv6/ip6_output.c | 37 ++++++++++++++++-----
tools/testing/selftests/net/msg_zerocopy.c | 3 +-
tools/testing/selftests/net/msg_zerocopy.sh | 2 ++
tools/testing/selftests/net/udpgso_bench.sh | 3 ++
9 files changed, 90 insertions(+), 27 deletions(-)
--
2.20.0.rc1.387.gf8505762e3-goog
next reply other threads:[~2018-12-01 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 20:32 Willem de Bruijn [this message]
2018-11-30 20:32 ` [PATCH net-next v4 1/3] udp: msg_zerocopy Willem de Bruijn
2018-12-03 12:46 ` Paolo Abeni
2018-11-30 20:32 ` [PATCH net-next v4 2/3] udp: elide zerocopy operation in hot path Willem de Bruijn
2018-12-03 12:50 ` Paolo Abeni
2018-11-30 20:32 ` [PATCH net-next v4 3/3] selftests: extend zerocopy tests to udp Willem de Bruijn
2018-12-03 23:59 ` [PATCH net-next v4 0/3] udp msg_zerocopy David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130203241.205490-1-willemdebruijn.kernel@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).