From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: phy: Also request modules for C45 IDs
Date: Fri, 30 Nov 2018 22:29:13 +0100
Message-ID: <20181130212913.GD25748@lunn.ch>
References: <d5f7b5c06f52ef757684be7b40a058c363d454bc.1543584362.git.joabreu@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <joao.pinto@synopsys.com>
To: Jose Abreu <jose.abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:56463 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725749AbeLAIjz (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 1 Dec 2018 03:39:55 -0500
Content-Disposition: inline
In-Reply-To: <d5f7b5c06f52ef757684be7b40a058c363d454bc.1543584362.git.joabreu@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> @@ -606,6 +606,18 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id,
>  	 * there's no driver _already_ loaded.
>  	 */
>  	request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT, MDIO_ID_ARGS(phy_id));

This line above is for C22. If you look at phy_bus_match(), it will
perform a match on the c45_ids->device_ids[] if it is a c45 PHY, or
the phy_id if it is c22. So i think we should also have this one or
the other here, not both.

Thanks
	Andrew

> +	if (c45_ids) {
> +		const int num_ids = ARRAY_SIZE(c45_ids->device_ids);
> +		int i;
> +
> +		for (i = 1; i < num_ids; i++) {
> +			if (!(c45_ids->devices_in_package & (1 << i)))
> +				continue;
> +
> +			request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT,
> +				       MDIO_ID_ARGS(c45_ids->device_ids[i]));
> +		}
> +	}
>  
>  	device_initialize(&mdiodev->dev);
>  
> -- 
> 2.7.4
> 
>