From: David Miller <davem@davemloft.net>
To: jerinjacobk@gmail.com
Cc: netdev@vger.kernel.org, sgoutham@marvell.com,
lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com
Subject: Re: [PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS flow key cfg message
Date: Sat, 01 Dec 2018 17:30:36 -0800 (PST) [thread overview]
Message-ID: <20181201.173036.1792318954498719294.davem@davemloft.net> (raw)
In-Reply-To: <20181201091403.30166-3-jerinjacobk@gmail.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Sat, 1 Dec 2018 14:43:51 +0530
> +#define FLOW_KEY_TYPE_PORT BIT(0)
> +#define FLOW_KEY_TYPE_IPV4 BIT(1)
> +#define FLOW_KEY_TYPE_IPV6 BIT(2)
> +#define FLOW_KEY_TYPE_TCP BIT(3)
> +#define FLOW_KEY_TYPE_UDP BIT(4)
> +#define FLOW_KEY_TYPE_SCTP BIT(5)
This is asking for serious global namespace collisions, as we have
various FLOW_* definitions coming from include/uapi/linux/pkt_cls.h
for example.
Please put some appropriate driver prefix to these macro names.
Thanks.
next prev parent reply other threads:[~2018-12-02 12:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 9:13 [PATCH v1 net-next 00/14] octeontx2-af: NIX and NPC enhancements Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 01/14] octeontx2-af: Skip NIXLF check for bcast MCE entry Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 02/14] octeontx2-af: Add response for RSS flow key cfg message Jerin Jacob
2018-12-02 1:30 ` David Miller [this message]
2018-12-01 9:13 ` [PATCH v1 net-next 03/14] octeontx2-af: Add support for dynamic flow cfg to RSS field generation Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 04/14] octeontx2-af: Add support for runtime RSS algo index reservation Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 05/14] octeontx2-af: Restrict TL1 allocation and configuration Jerin Jacob
2018-12-02 1:31 ` David Miller
2018-12-01 9:13 ` [PATCH v1 net-next 06/14] octeontx2-af: Allow freeing single TLx Tx schedule queue Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 07/14] octeontx2-af: Enable inner IPv4 checksum and its error code Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 08/14] octeontx2-af: Define all NIX_AF_RX_DEF_* registers Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 09/14] octeontx2-af: Enable RSS with promiscuous mode Jerin Jacob
2018-12-01 9:13 ` [PATCH v1 net-next 10/14] octeontx2-af: Add support for Tx packet marking Jerin Jacob
2018-12-01 9:14 ` [PATCH v1 net-next 11/14] octeontx2-af: Configure VLAN TPIDs Jerin Jacob
2018-12-01 9:14 ` [PATCH v1 net-next 12/14] octeontx2-af: Add L3 and L4 packet verification mailbox Jerin Jacob
2018-12-01 9:14 ` [PATCH v1 net-next 13/14] octeontx2-af: Add LSO format configuration mailbox Jerin Jacob
2018-12-01 9:14 ` [PATCH v1 net-next 14/14] octeontx2-af: Enable mkex profile Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201.173036.1792318954498719294.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).