From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net/core: tidy up an error message Date: Sat, 1 Dec 2018 09:17:22 -0800 Message-ID: <20181201091722.6c9a8f06@xeon-e3> References: <20181201045153.4035-1-cai@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, yisen.zhuang@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Qian Cai Return-path: Received: from mail-pl1-f173.google.com ([209.85.214.173]:45381 "EHLO mail-pl1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727040AbeLBEaY (ORCPT ); Sat, 1 Dec 2018 23:30:24 -0500 Received: by mail-pl1-f173.google.com with SMTP id a14so4343961plm.12 for ; Sat, 01 Dec 2018 09:17:25 -0800 (PST) In-Reply-To: <20181201045153.4035-1-cai@gmx.us> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 30 Nov 2018 23:51:53 -0500 Qian Cai wrote: > + weight, > + !strchr(dev->name, '%') ? dev->name : "unknown" Agree with Joe, use netdev_err_once or use netdev_name().