From: David Miller <davem@davemloft.net>
To: jose.abreu@synopsys.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
joao.pinto@synopsys.com
Subject: Re: [PATCH net-next v2] net: phy: Also request modules for C45 IDs
Date: Mon, 03 Dec 2018 16:33:28 -0800 (PST) [thread overview]
Message-ID: <20181203.163328.552139970988149764.davem@davemloft.net> (raw)
In-Reply-To: <beb4b2e3946fc0d7252804a8458c7643f67c1dfc.1543764549.git.joabreu@synopsys.com>
From: Jose Abreu <jose.abreu@synopsys.com>
Date: Sun, 2 Dec 2018 16:33:14 +0100
> Logic of phy_device_create() requests PHY modules according to PHY ID
> but for C45 PHYs we use different field for the IDs.
>
> Let's also request the modules for these IDs.
>
> Changes from v1:
> - Only request C22 modules if C45 are not present (Andrew)
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Applied, thanks Jose.
Florian, just for the record, I actually like the changelogs to be in
the commit messages. It can help people understand that something
was deliberately implemented a certain way and alternative approaches
were considered.
prev parent reply other threads:[~2018-12-04 0:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 15:33 [PATCH net-next v2] net: phy: Also request modules for C45 IDs Jose Abreu
2018-12-02 16:09 ` Andrew Lunn
2018-12-02 17:30 ` Florian Fainelli
2018-12-04 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203.163328.552139970988149764.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).