From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2] net: phy: Also request modules for C45 IDs Date: Mon, 03 Dec 2018 16:33:28 -0800 (PST) Message-ID: <20181203.163328.552139970988149764.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, joao.pinto@synopsys.com To: jose.abreu@synopsys.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:51044 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbeLDAda (ORCPT ); Mon, 3 Dec 2018 19:33:30 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jose Abreu Date: Sun, 2 Dec 2018 16:33:14 +0100 > Logic of phy_device_create() requests PHY modules according to PHY ID > but for C45 PHYs we use different field for the IDs. > > Let's also request the modules for these IDs. > > Changes from v1: > - Only request C22 modules if C45 are not present (Andrew) > > Signed-off-by: Jose Abreu Applied, thanks Jose. Florian, just for the record, I actually like the changelogs to be in the commit messages. It can help people understand that something was deliberately implemented a certain way and alternative approaches were considered.