* [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE
@ 2018-12-03 14:13 Yangtao Li
2018-12-03 18:53 ` Jakub Kicinski
2018-12-04 1:29 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2018-12-03 14:13 UTC (permalink / raw)
To: jakub.kicinski, davem, nick.viljoen, joe
Cc: oss-drivers, netdev, linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
.../ethernet/netronome/nfp/nfp_net_debugfs.c | 42 ++++---------------
1 file changed, 7 insertions(+), 35 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c b/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c
index 69b1c9b62e3d..f314cc9966b3 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c
@@ -8,7 +8,7 @@
static struct dentry *nfp_dir;
-static int nfp_net_debugfs_rx_q_read(struct seq_file *file, void *data)
+static int nfp_rx_q_show(struct seq_file *file, void *data)
{
struct nfp_net_r_vector *r_vec = file->private;
struct nfp_net_rx_ring *rx_ring;
@@ -65,31 +65,9 @@ static int nfp_net_debugfs_rx_q_read(struct seq_file *file, void *data)
rtnl_unlock();
return 0;
}
+DEFINE_SHOW_ATTRIBUTE(nfp_rx_q);
-static int nfp_net_debugfs_rx_q_open(struct inode *inode, struct file *f)
-{
- return single_open(f, nfp_net_debugfs_rx_q_read, inode->i_private);
-}
-
-static const struct file_operations nfp_rx_q_fops = {
- .owner = THIS_MODULE,
- .open = nfp_net_debugfs_rx_q_open,
- .release = single_release,
- .read = seq_read,
- .llseek = seq_lseek
-};
-
-static int nfp_net_debugfs_tx_q_open(struct inode *inode, struct file *f);
-
-static const struct file_operations nfp_tx_q_fops = {
- .owner = THIS_MODULE,
- .open = nfp_net_debugfs_tx_q_open,
- .release = single_release,
- .read = seq_read,
- .llseek = seq_lseek
-};
-
-static int nfp_net_debugfs_tx_q_read(struct seq_file *file, void *data)
+static int nfp_tx_q_show(struct seq_file *file, void *data)
{
struct nfp_net_r_vector *r_vec = file->private;
struct nfp_net_tx_ring *tx_ring;
@@ -157,19 +135,13 @@ static int nfp_net_debugfs_tx_q_read(struct seq_file *file, void *data)
rtnl_unlock();
return 0;
}
+DEFINE_SHOW_ATTRIBUTE(nfp_tx_q);
-static int nfp_net_debugfs_tx_q_open(struct inode *inode, struct file *f)
+static int nfp_xdp_q_show(struct seq_file *file, void *data)
{
- return single_open(f, nfp_net_debugfs_tx_q_read, inode->i_private);
+ return nfp_tx_q_show(file, data);
}
-
-static const struct file_operations nfp_xdp_q_fops = {
- .owner = THIS_MODULE,
- .open = nfp_net_debugfs_tx_q_open,
- .release = single_release,
- .read = seq_read,
- .llseek = seq_lseek
-};
+DEFINE_SHOW_ATTRIBUTE(nfp_xdp_q);
void nfp_net_debugfs_vnic_add(struct nfp_net *nn, struct dentry *ddir)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-03 14:13 [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
@ 2018-12-03 18:53 ` Jakub Kicinski
2018-12-04 1:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2018-12-03 18:53 UTC (permalink / raw)
To: Yangtao Li; +Cc: davem, nick.viljoen, joe, oss-drivers, netdev, linux-kernel
On Mon, 3 Dec 2018 09:13:35 -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE
2018-12-03 14:13 [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-03 18:53 ` Jakub Kicinski
@ 2018-12-04 1:29 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-12-04 1:29 UTC (permalink / raw)
To: tiny.windzz
Cc: jakub.kicinski, nick.viljoen, joe, oss-drivers, netdev,
linux-kernel
From: Yangtao Li <tiny.windzz@gmail.com>
Date: Mon, 3 Dec 2018 09:13:35 -0500
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-04 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-03 14:13 [PATCH] nfp: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-03 18:53 ` Jakub Kicinski
2018-12-04 1:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).