From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC bpf-next 1/7] bpf: interpreter support BPF_ALU | BPF_ARSH Date: Tue, 04 Dec 2018 08:43:11 -0800 (PST) Message-ID: <20181204.084311.1463740646371452255.davem@davemloft.net> References: <1543917395-6130-1-git-send-email-jiong.wang@netronome.com> <1543917395-6130-2-git-send-email-jiong.wang@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com To: jiong.wang@netronome.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:40292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeLDQnM (ORCPT ); Tue, 4 Dec 2018 11:43:12 -0500 In-Reply-To: <1543917395-6130-2-git-send-email-jiong.wang@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiong Wang Date: Tue, 4 Dec 2018 04:56:29 -0500 > This patch implements interpreting BPF_ALU | BPF_ARSH. Do arithmetic right > shift on low 32-bit sub-register, and zero the high 32 bits. > > Reviewed-by: Jakub Kicinski > Signed-off-by: Jiong Wang I just want to say that this behavior is interesting because on most cpus that have a 32-bit and 64-bit variant, the 32-bit arithmetic right shift typically sign extends to 64-bit rather than zero extends which is what is being defined here. Well, definitely, sparc64 behaves this way.