netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: posk@google.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
	posk.devel@gmail.com, edumazet@google.com
Subject: Re: [PATCH net-next] net: netem: use a list in addition to rbtree
Date: Tue, 04 Dec 2018 12:07:58 -0800 (PST)	[thread overview]
Message-ID: <20181204.120758.1965872181031946393.davem@davemloft.net> (raw)
In-Reply-To: <CAPNVh5eKjgKBinsVs=6SZ0uo9vacji5qztsazUodEnzppAD4pg@mail.gmail.com>

From: Peter Oskolkov <posk@google.com>
Date: Tue, 4 Dec 2018 11:10:55 -0800

> Thanks, Stephen!
> 
> I don't care much about braces either. David, do you want me to send a
> new patch with braces moved around?

Single statement basic blocks definitely must not have curly braces,
please remove them and repost.

Thank you.

      parent reply	other threads:[~2018-12-04 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  1:07 [PATCH net-next] net: netem: use a list in addition to rbtree Peter Oskolkov
2018-12-04 15:57 ` Eric Dumazet
2018-12-04 17:56 ` Stephen Hemminger
2018-12-04 19:10   ` Peter Oskolkov
2018-12-04 19:58     ` Peter Oskolkov
2018-12-04 20:07     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204.120758.1965872181031946393.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=posk.devel@gmail.com \
    --cc=posk@google.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).