From: David Miller <davem@davemloft.net>
To: jakub.audykowicz@gmail.com
Cc: linux-sctp@vger.kernel.org, vyasevich@gmail.com,
nhorman@tuxdriver.com, marcelo.leitner@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] sctp: frag_point sanity check
Date: Wed, 05 Dec 2018 20:16:15 -0800 (PST) [thread overview]
Message-ID: <20181205.201615.2105941098946347576.davem@davemloft.net> (raw)
In-Reply-To: <20181204192741.35357-1-jakub.audykowicz@gmail.com>
From: Jakub Audykowicz <jakub.audykowicz@gmail.com>
Date: Tue, 4 Dec 2018 20:27:41 +0100
> If for some reason an association's fragmentation point is zero,
> sctp_datamsg_from_user will try to endlessly try to divide a message
> into zero-sized chunks. This eventually causes kernel panic due to
> running out of memory.
>
> Although this situation is quite unlikely, it has occurred before as
> reported. I propose to add this simple last-ditch sanity check due to
> the severity of the potential consequences.
>
> Signed-off-by: Jakub Audykowicz <jakub.audykowicz@gmail.com>
Applied.
prev parent reply other threads:[~2018-12-06 4:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 19:27 [PATCH net] sctp: frag_point sanity check Jakub Audykowicz
2018-12-04 19:39 ` Neil Horman
2018-12-04 19:52 ` Marcelo Ricardo Leitner
2018-12-04 20:56 ` Neil Horman
2018-12-04 20:59 ` Marcelo Ricardo Leitner
2018-12-06 2:49 ` kbuild test robot
2018-12-06 4:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205.201615.2105941098946347576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.audykowicz@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).