netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, pjt@google.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead
Date: Wed, 05 Dec 2018 20:49:58 -0800 (PST)	[thread overview]
Message-ID: <20181205.204958.1878018442106277817.davem@davemloft.net> (raw)
In-Reply-To: <cover.1544032300.git.pabeni@redhat.com>

From: Paolo Abeni <pabeni@redhat.com>
Date: Wed,  5 Dec 2018 19:13:38 +0100

 ...
> This may lead to some uglification around the indirect calls. In netconf 2018
> Eric Dumazet described a technique to hide the most relevant part of the needed
> boilerplate with some macro help.
> 
> This series is a [re-]implementation of such idea, exposing the introduced
> helpers in a new header file. They are later leveraged to avoid the indirect
> call overhead in the GRO path, when possible.
> 
> Overall this gives > 10% performance improvement for UDP GRO benchmark and
> smaller but measurable for TCP syn flood.
> 
> The added infra can be used in follow-up patches to cope with retpoline overhead
> in other points of the networking stack (e.g. at the qdisc layer) and possibly
> even in other subsystems.
 ...

I like this a lot and unless I hear some objections I'm going to apply this
series tomorrow.

Thanks for working on this Paolo.

  parent reply	other threads:[~2018-12-06  4:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 18:13 [PATCH net-next v2 0/4] net: mitigate retpoline overhead Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 1/4] indirect call wrappers: helpers to speed-up indirect calls of builtin Paolo Abeni
2018-12-07  9:46   ` David Woodhouse
2018-12-07 20:46     ` Paolo Abeni
2018-12-07 21:46       ` David Woodhouse
2018-12-11 22:28         ` Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 2/4] net: use indirect call wrappers at GRO network layer Paolo Abeni
2018-12-05 18:13 ` [PATCH net-next v2 3/4] net: use indirect call wrappers at GRO transport layer Paolo Abeni
2018-12-21  2:57   ` Stephen Hemminger
2018-12-05 18:13 ` [PATCH net-next v2 4/4] udp: use indirect call wrappers for GRO socket lookup Paolo Abeni
2018-12-06  4:49 ` David Miller [this message]
2018-12-07  6:24 ` [PATCH net-next v2 0/4] net: mitigate retpoline overhead David Miller
2018-12-07  6:28   ` David Miller
2018-12-07 20:29     ` Paolo Abeni
2018-12-07 21:06       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205.204958.1878018442106277817.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).