From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Khoronzhuk Subject: Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists Date: Wed, 5 Dec 2018 02:04:51 +0200 Message-ID: <20181205000450.GB3507@khorivan> References: <20181203184023.3430-1-ivan.khoronzhuk@linaro.org> <20181203184023.3430-3-ivan.khoronzhuk@linaro.org> <20181203235119.GF23230@khorivan> <35479973-2d2d-d673-f7ab-54d6369ce3d1@gmail.com> <20181204185720.GI23230@khorivan> <756cbb25-3062-91e8-0613-66bb887f937e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@mellanox.com, andrew@lunn.ch To: Florian Fainelli Return-path: Received: from mail-lf1-f66.google.com ([209.85.167.66]:42800 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbeLEAE4 (ORCPT ); Tue, 4 Dec 2018 19:04:56 -0500 Received: by mail-lf1-f66.google.com with SMTP id l10so13337973lfh.9 for ; Tue, 04 Dec 2018 16:04:55 -0800 (PST) Content-Disposition: inline In-Reply-To: <756cbb25-3062-91e8-0613-66bb887f937e@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 04, 2018 at 11:49:27AM -0800, Florian Fainelli wrote: ... >> >> I was thinking also about pinned list of vlans to the address, but in >> this case this information also has to be synced by members of device >> chain, >> because it can be modified on any device level and it looks not very >> friendly, >> and at the end address space has addresses with pinned lists of vlans with >> their pointers. But keeping this stuff in sync is not simplest decision. >> >> > >I really think we are not communicating properly, it really seems to me >that if you had the information about the upper device trying to add an >address to the lower device filter's either through notification or call >to ndo_set_rxmode, you could be solving your problems. What are we >missing here? Sry, missed this one. The problem in getting the owner of address. Just simple case: vlan/macvlan/real_dev or vlan/.../.../real_dev The real dev hasn't simple way to get vid the address belong to, or it has? >-- >Florian -- Regards, Ivan Khoronzhuk