From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next RFC 2/7] devlink: Add port param get command Date: Wed, 5 Dec 2018 12:51:18 +0100 Message-ID: <20181205115118.GC2318@nanopsycho> References: <1543989420-14859-1-git-send-email-vasundhara-v.volam@broadcom.com> <1543989420-14859-3-git-send-email-vasundhara-v.volam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, netdev@vger.kernel.org To: Vasundhara Volam Return-path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:45735 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbeLEL6Y (ORCPT ); Wed, 5 Dec 2018 06:58:24 -0500 Received: by mail-wr1-f67.google.com with SMTP id b14so5801912wru.12 for ; Wed, 05 Dec 2018 03:58:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <1543989420-14859-3-git-send-email-vasundhara-v.volam@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, Dec 05, 2018 at 06:56:55AM CET, vasundhara-v.volam@broadcom.com wrote: >Add port param get command which gets data per parameter. >It also has option to dump the parameters data per port. > >Cc: Jiri Pirko >Signed-off-by: Vasundhara Volam >--- > include/uapi/linux/devlink.h | 2 + > net/core/devlink.c | 102 ++++++++++++++++++++++++++++++++++++++++--- > 2 files changed, 97 insertions(+), 7 deletions(-) > >diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h >index 6e52d36..f96e052 100644 >--- a/include/uapi/linux/devlink.h >+++ b/include/uapi/linux/devlink.h >@@ -83,6 +83,8 @@ enum devlink_command { > DEVLINK_CMD_PARAM_NEW, > DEVLINK_CMD_PARAM_DEL, > >+ DEVLINK_CMD_PORT_PARAM_GET, /* can dump */ You need to add this to the end, otherwise you would break uapi. >+ > DEVLINK_CMD_REGION_GET, > DEVLINK_CMD_REGION_SET, > DEVLINK_CMD_REGION_NEW, [...] The rest of the patch looks fine.