From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port params table and register it Date: Wed, 5 Dec 2018 15:33:09 -0800 Message-ID: <20181205153309.3fa92dd5@cakuba.netronome.com> References: <1543989420-14859-1-git-send-email-vasundhara-v.volam@broadcom.com> <1543989420-14859-8-git-send-email-vasundhara-v.volam@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, netdev@vger.kernel.org To: Vasundhara Volam Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:34617 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbeLEXd3 (ORCPT ); Wed, 5 Dec 2018 18:33:29 -0500 Received: by mail-pl1-f195.google.com with SMTP id w4so10827842plz.1 for ; Wed, 05 Dec 2018 15:33:29 -0800 (PST) In-Reply-To: <1543989420-14859-8-git-send-email-vasundhara-v.volam@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 5 Dec 2018 11:27:00 +0530, Vasundhara Volam wrote: > Register devlink_port with devlink and create initial port params > table for bnxt_en. The table consists of a generic parameter: > > wake-on-lan: Enables Wake on Lan for this port when magic packet > is received with this port's MAC address using ACPI pattern. > If enabled, the controller asserts a wake pin upon reception of > WoL packet. ACPI (Advanced Configuration and Power Interface) is > an industry specification for the efficient handling of power > consumption in desktop and mobile computers. > > Cc: Michael Chan > Signed-off-by: Vasundhara Volam Why do we need a WoL as a devlink parameter (rather than ethtool -s)?