From: David Miller <davem@davemloft.net>
To: dsahern@kernel.org
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, dsahern@gmail.com
Subject: Re: [PATCH net-next] neighbour: Improve garbage collection
Date: Thu, 06 Dec 2018 19:59:15 -0800 (PST) [thread overview]
Message-ID: <20181206.195915.1229694119610331965.davem@davemloft.net> (raw)
In-Reply-To: <20181206223844.29142-1-dsahern@kernel.org>
From: David Ahern <dsahern@kernel.org>
Date: Thu, 6 Dec 2018 14:38:44 -0800
> The existing garbage collection algorithm has a number of problems:
Thanks for working on this!
I totally agree with what you are doing, especially the separate
gc_list.
But why do you need the on_gc_list boolean state? That's equivalent
to "!list_empty(&n->gc_list)" and seems redundant.
next prev parent reply other threads:[~2018-12-07 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 22:38 [PATCH net-next] neighbour: Improve garbage collection David Ahern
2018-12-07 3:59 ` David Miller [this message]
2018-12-07 19:54 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206.195915.1229694119610331965.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).