From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] neighbour: Improve garbage collection
Date: Thu, 06 Dec 2018 19:59:15 -0800 (PST)
Message-ID: <20181206.195915.1229694119610331965.davem@davemloft.net>
References: <20181206223844.29142-1-dsahern@kernel.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
        dsahern@gmail.com
To: dsahern@kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:47978 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725939AbeLGD7S (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 6 Dec 2018 22:59:18 -0500
In-Reply-To: <20181206223844.29142-1-dsahern@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: David Ahern <dsahern@kernel.org>
Date: Thu,  6 Dec 2018 14:38:44 -0800

> The existing garbage collection algorithm has a number of problems:

Thanks for working on this!

I totally agree with what you are doing, especially the separate
gc_list.

But why do you need the on_gc_list boolean state?  That's equivalent
to "!list_empty(&n->gc_list)" and seems redundant.