From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port
 params table and register it
Date: Thu, 6 Dec 2018 10:03:58 +0100
Message-ID: <20181206090358.GJ2318@nanopsycho>
References: <1543989420-14859-1-git-send-email-vasundhara-v.volam@broadcom.com>
 <1543989420-14859-8-git-send-email-vasundhara-v.volam@broadcom.com>
 <20181205153309.3fa92dd5@cakuba.netronome.com>
 <CACKFLikR5G1vca31hyjJ3uZbV1Zq-86a9=qXeUaO1gqosDg9GQ@mail.gmail.com>
 <20181205164203.230c44e8@cakuba.netronome.com>
 <CACKFLinvfruoDiR3_DetmpXdQT4+Sf759nh+C+hJq41YWnMk-g@mail.gmail.com>
 <20181205220038.503d6a92@cakuba.netronome.com>
 <CACKFLi=XjLjqZyWrf+jWPbyAJUe3Obf8NaOpHJDJGvLHPHhf_w@mail.gmail.com>
 <20181205231120.339c5f50@cakuba.netronome.com>
 <CACKFLinKxO64nx8ewEEO726dzvSMTr29W3_6kmqVFzunkVLq4A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
        Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
        David Miller <davem@davemloft.net>,
        Jiri Pirko <jiri@mellanox.com>, Netdev <netdev@vger.kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f68.google.com ([209.85.221.68]:42912 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728566AbeLFJLD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 6 Dec 2018 04:11:03 -0500
Received: by mail-wr1-f68.google.com with SMTP id q18so22426825wrx.9
        for <netdev@vger.kernel.org>; Thu, 06 Dec 2018 01:11:02 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CACKFLinKxO64nx8ewEEO726dzvSMTr29W3_6kmqVFzunkVLq4A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thu, Dec 06, 2018 at 09:57:05AM CET, michael.chan@broadcom.com wrote:
>On Wed, Dec 5, 2018 at 11:11 PM Jakub Kicinski
><jakub.kicinski@netronome.com> wrote:
>>
>> On Wed, 5 Dec 2018 22:41:43 -0800, Michael Chan wrote:
>> >
>> > It will be in the BIOS only for a LOM, I think.  For a NIC, it should
>> > be in the NIC's NVRAM.
>>
>> This is all vague.  Could you please clearly state the use case.
>>
>Well, the WoL setting's use case should be quite simple, right?  If
>the card's NVRAM WoL setting is ON, when you plug the card in a slot
>that has Vaux power, it will assert PME# when a magic packet is
>received.  Again, the WoL setting in this context is similar to other
>power up settings such as PCIe Gen2 or Gen3.
>
>Let's say the power up setting is ON and it boots up to Linux for the
>first time after receiving a magic packet.  The Linux user can then
>run ethtool -s to set the driver's non persistent WoL setting.  It can
>be the same as the NVRAM's power up setting, or different.  Ethtool
>may support additional WoL packet types that the power up setting does

Wouldn't it make sense to also support multiple wol packet types in
devlink param, not just true/false? Your device may not support that but
others may. So enum instead of bool.


>not support.  Let's say the Linux user sets the ethtool WoL setting to
>OFF and shuts down the system.  That card now will not wake up the
>system.  But if there is a power failure and power comes back on
>later, the card will lose the ethtool setting and go back to the power
>up WoL setting, which is ON in this example.