Re: [PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port params table and register it

[Jiri Pirko <jiri@resnulli.us>]

Thu, Dec 06, 2018 at 11:31:26AM CET, vasundhara-v.volam@broadcom.com wrote:
>On Thu, Dec 6, 2018 at 2:41 PM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Thu, Dec 06, 2018 at 09:57:05AM CET, michael.chan@broadcom.com wrote:
>> >On Wed, Dec 5, 2018 at 11:11 PM Jakub Kicinski
>> ><jakub.kicinski@netronome.com> wrote:
>> >>
>> >> On Wed, 5 Dec 2018 22:41:43 -0800, Michael Chan wrote:
>> >> >
>> >> > It will be in the BIOS only for a LOM, I think.  For a NIC, it should
>> >> > be in the NIC's NVRAM.
>> >>
>> >> This is all vague.  Could you please clearly state the use case.
>> >>
>> >Well, the WoL setting's use case should be quite simple, right?  If
>> >the card's NVRAM WoL setting is ON, when you plug the card in a slot
>> >that has Vaux power, it will assert PME# when a magic packet is
>> >received.  Again, the WoL setting in this context is similar to other
>> >power up settings such as PCIe Gen2 or Gen3.
>> >
>> >Let's say the power up setting is ON and it boots up to Linux for the
>> >first time after receiving a magic packet.  The Linux user can then
>> >run ethtool -s to set the driver's non persistent WoL setting.  It can
>> >be the same as the NVRAM's power up setting, or different.  Ethtool
>> >may support additional WoL packet types that the power up setting does
>>
>> Wouldn't it make sense to also support multiple wol packet types in
>> devlink param, not just true/false? Your device may not support that but
>> others may. So enum instead of bool.
>There is no type enum in devlink types as of now. Instead it can be
>defined as u8 and
>a enum structure can be defined for wol types.

Yes.

>>
>>
>> >not support.  Let's say the Linux user sets the ethtool WoL setting to
>> >OFF and shuts down the system.  That card now will not wake up the
>> >system.  But if there is a power failure and power comes back on
>> >later, the card will lose the ethtool setting and go back to the power
>> >up WoL setting, which is ON in this example.