From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port params table and register it Date: Thu, 6 Dec 2018 12:11:06 +0100 Message-ID: <20181206111106.GK2318@nanopsycho> References: <20181205153309.3fa92dd5@cakuba.netronome.com> <20181205164203.230c44e8@cakuba.netronome.com> <20181205220038.503d6a92@cakuba.netronome.com> <20181205231120.339c5f50@cakuba.netronome.com> <20181206090358.GJ2318@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "michael.chan@broadcom.com" , jakub.kicinski@netronome.com, David Miller , Jiri Pirko , Netdev To: Vasundhara Volam Return-path: Received: from mail-wr1-f66.google.com ([209.85.221.66]:41940 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeLFLSM (ORCPT ); Thu, 6 Dec 2018 06:18:12 -0500 Received: by mail-wr1-f66.google.com with SMTP id x10so73523wrs.8 for ; Thu, 06 Dec 2018 03:18:11 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Thu, Dec 06, 2018 at 11:31:26AM CET, vasundhara-v.volam@broadcom.com wrote: >On Thu, Dec 6, 2018 at 2:41 PM Jiri Pirko wrote: >> >> Thu, Dec 06, 2018 at 09:57:05AM CET, michael.chan@broadcom.com wrote: >> >On Wed, Dec 5, 2018 at 11:11 PM Jakub Kicinski >> > wrote: >> >> >> >> On Wed, 5 Dec 2018 22:41:43 -0800, Michael Chan wrote: >> >> > >> >> > It will be in the BIOS only for a LOM, I think. For a NIC, it should >> >> > be in the NIC's NVRAM. >> >> >> >> This is all vague. Could you please clearly state the use case. >> >> >> >Well, the WoL setting's use case should be quite simple, right? If >> >the card's NVRAM WoL setting is ON, when you plug the card in a slot >> >that has Vaux power, it will assert PME# when a magic packet is >> >received. Again, the WoL setting in this context is similar to other >> >power up settings such as PCIe Gen2 or Gen3. >> > >> >Let's say the power up setting is ON and it boots up to Linux for the >> >first time after receiving a magic packet. The Linux user can then >> >run ethtool -s to set the driver's non persistent WoL setting. It can >> >be the same as the NVRAM's power up setting, or different. Ethtool >> >may support additional WoL packet types that the power up setting does >> >> Wouldn't it make sense to also support multiple wol packet types in >> devlink param, not just true/false? Your device may not support that but >> others may. So enum instead of bool. >There is no type enum in devlink types as of now. Instead it can be >defined as u8 and >a enum structure can be defined for wol types. Yes. >> >> >> >not support. Let's say the Linux user sets the ethtool WoL setting to >> >OFF and shuts down the system. That card now will not wake up the >> >system. But if there is a power failure and power comes back on >> >later, the card will lose the ethtool setting and go back to the power >> >up WoL setting, which is ON in this example.