From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads
Date: Thu, 6 Dec 2018 14:14:04 -0800 [thread overview]
Message-ID: <20181206141404.3f6f2ebe@xeon-e3> (raw)
In-Reply-To: <1544092565-11311-3-git-send-email-andrew@lunn.ch>
On Thu, 6 Dec 2018 11:36:05 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> +void dsa_master_set_mtu(struct net_device *dev, struct dsa_port *cpu_dp)
> +{
> + unsigned int mtu = ETH_DATA_LEN + cpu_dp->tag_ops->overhead;
> + int err;
> +
> + rtnl_lock();
> + if (mtu <= dev->max_mtu) {
> + err = dev_set_mtu(dev, mtu);
> + if (err)
> + netdev_dbg(dev, "Unable to set MTU to include for DSA overheads\n");
> + }
> + rtnl_unlock();
> +}
> +
You don't need the debug message. Use err_ack instead?
Debug messages are usually disabled in most distributions.
next prev parent reply other threads:[~2018-12-06 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 10:36 [PATCH net-next 0/2] Adjust MTU of DSA master interface Andrew Lunn
2018-12-06 10:36 ` [PATCH net-next 1/2] net: dsa: Add overhead to tag protocol ops Andrew Lunn
2018-12-06 10:36 ` [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads Andrew Lunn
2018-12-06 20:21 ` Florian Fainelli
2018-12-06 20:48 ` Andrew Lunn
2018-12-06 21:35 ` David Miller
2018-12-06 22:14 ` Stephen Hemminger [this message]
2018-12-06 20:18 ` [PATCH net-next 0/2] Adjust MTU of DSA master interface David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206141404.3f6f2ebe@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox