From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] gianfar: Add gfar_change_carrier()
Date: Thu, 6 Dec 2018 17:54:19 +0100 [thread overview]
Message-ID: <20181206165419.GI18674@lunn.ch> (raw)
In-Reply-To: <aea0bca93adf7ce9a6b3324420d1fee09f51a44d.camel@infinera.com>
> I wish I had a proper DSA/Switchdev driver in place but I don't :(
> Adding one is not impossible but then a lot of our user space app needs fixing so all
> in all it it a fairly big project.
> Anyhow, these carrier additions should be fine I think?
I'm not too sure about that. You are potentially messing up the state
machine, and the MAC driver could be looking at phydev->link, which
says up, but the carrier is down.
https://www.kernel.org/doc/Documentation/networking/operstates.txt
Could you set the interface to dormant? That seems like a better fit
anyway:
IF_OPER_DORMANT (5):
Interface is L1 up, but waiting for an external event, f.e. for a
protocol to establish. (802.1X)
The interface does have L1 to the switch, but you are waiting for the
external interface to go up. You can set this from user space without
needing any kernel changes.
Andrew
next prev parent reply other threads:[~2018-12-06 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:31 [PATCH] gianfar: Add gfar_change_carrier() Joakim Tjernlund
2018-12-06 15:47 ` Andrew Lunn
2018-12-06 16:02 ` Joakim Tjernlund
2018-12-06 16:21 ` Andrew Lunn
2018-12-06 16:31 ` Joakim Tjernlund
2018-12-06 16:54 ` Andrew Lunn [this message]
2018-12-06 18:46 ` Joakim Tjernlund
2018-12-06 19:43 ` Andrew Lunn
2018-12-07 14:07 ` Joakim Tjernlund
2018-12-07 14:15 ` Andrew Lunn
2018-12-07 17:01 ` Joakim Tjernlund
2018-12-07 17:26 ` Andrew Lunn
2018-12-07 20:40 ` Florian Fainelli
2018-12-10 15:37 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206165419.GI18674@lunn.ch \
--to=andrew@lunn.ch \
--cc=Joakim.Tjernlund@infinera.com \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).