From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: mv88e6060: Turn e6060 driver into e6065 driver Date: Thu, 6 Dec 2018 21:35:22 +0100 Message-ID: <20181206203522.GA26718@amd> References: <20181115195111.GA9946@amd> <20181206130051.GA22343@amd> <20181206130345.GD22343@amd> <20181206.122333.646375739770814733.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, f.fainelli@gmail.com, buytenh@marvell.com, buytenh@wantstofly.org, nico@marvell.com To: David Miller Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47348 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbeLFUfZ (ORCPT ); Thu, 6 Dec 2018 15:35:25 -0500 Content-Disposition: inline In-Reply-To: <20181206.122333.646375739770814733.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2018-12-06 12:23:33, David Miller wrote: > From: Pavel Machek > Date: Thu, 6 Dec 2018 14:03:45 +0100 >=20 > > @@ -79,7 +82,7 @@ static enum dsa_tag_protocol mv88e6060_get_tag_protoc= ol(struct dsa_switch *ds, > > { > > //return DSA_TAG_PROTO_QCA; > > //return DSA_TAG_PROTO_TRAILER; >=20 > These C++ style comments are not in any of my tree(s). >=20 > Your patch submission really needs to shape up if you want your patches > to be considered seriously. This one should have been "RFD". It has way more serious problems then this, as changelog tried to explain. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwJiAoACgkQMOfwapXb+vICGQCdHUIAfP/aLGATX39EYylh7tpg 2lYAn1ZyYaTthMzzRmBKxS1vCFQBDo+L =X6Mz -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--