From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] mv88e6060: Warn about errors Date: Thu, 6 Dec 2018 21:36:49 +0100 Message-ID: <20181206203649.GA27153@amd> References: <20181115195111.GA9946@amd> <20181206130051.GA22343@amd> <20181206130145.GB22343@amd> <20181206.122159.185940398402192249.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org, f.fainelli@gmail.com, buytenh@marvell.com, buytenh@wantstofly.org, nico@marvell.com To: David Miller Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47432 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbeLFUgw (ORCPT ); Thu, 6 Dec 2018 15:36:52 -0500 Content-Disposition: inline In-Reply-To: <20181206.122159.185940398402192249.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2018-12-06 12:21:59, David Miller wrote: >=20 > Plain "printk" are never appropriate. >=20 > Please explicitly use pr_warn() or similar. If there is a device context > available, either a generic device or a netdev, use one of the dev_*() > or netdev_*() variants. Can do, I guess.... is there's agreeement that such error is worth some kind of output to the logs? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwJiGEACgkQMOfwapXb+vLgSgCfX0BoP8PwNoiiCmQKv/fdOy5N c0AAoJG47HIQKORbdePt2RNEdsD+1sMT =cP3m -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--