From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: netdev@vger.kernel.org, michaele@au1.ibm.com, fr0st61te@gmail.com
Subject: Re: [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"
Date: Fri, 07 Dec 2018 22:37:40 -0800 (PST) [thread overview]
Message-ID: <20181207.223740.800602386798041681.davem@davemloft.net> (raw)
In-Reply-To: <94b140ae5a60df4213aaa2d85cc403d01d1e436a.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Fri, 07 Dec 2018 15:05:04 +1100
> This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9.
>
> This commit is completely bogus. The STACR register has two formats, old
> and new, depending on the version of the IP block used. There's a pair of
> device-tree properties that can be used to specify the format used:
>
> has-inverted-stacr-oc
> has-new-stacr-staopc
>
> What this commit did was to change the bit definition used with the old
> parts to match the new parts. This of course breaks the driver on all
> the old ones.
>
> Instead, the author should have set the appropriate properties in the
> device-tree for the variant used on his board.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Found while setting up some old ppc440 boxes for test/CI
Applied, thanks.
next prev parent reply other threads:[~2018-12-08 6:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 4:05 [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control" Benjamin Herrenschmidt
2018-12-08 6:37 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-07 3:20 Benjamin Herrenschmidt
2018-12-07 3:59 ` David Miller
2018-12-07 4:05 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207.223740.800602386798041681.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=fr0st61te@gmail.com \
--cc=michaele@au1.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).