From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control" Date: Fri, 07 Dec 2018 22:37:40 -0800 (PST) Message-ID: <20181207.223740.800602386798041681.davem@davemloft.net> References: <94b140ae5a60df4213aaa2d85cc403d01d1e436a.camel@kernel.crashing.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, michaele@au1.ibm.com, fr0st61te@gmail.com To: benh@kernel.crashing.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:45792 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbeLHGhl (ORCPT ); Sat, 8 Dec 2018 01:37:41 -0500 In-Reply-To: <94b140ae5a60df4213aaa2d85cc403d01d1e436a.camel@kernel.crashing.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Benjamin Herrenschmidt Date: Fri, 07 Dec 2018 15:05:04 +1100 > This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9. > > This commit is completely bogus. The STACR register has two formats, old > and new, depending on the version of the IP block used. There's a pair of > device-tree properties that can be used to specify the format used: > > has-inverted-stacr-oc > has-new-stacr-staopc > > What this commit did was to change the bit definition used with the old > parts to match the new parts. This of course breaks the driver on all > the old ones. > > Instead, the author should have set the appropriate properties in the > device-tree for the variant used on his board. > > Signed-off-by: Benjamin Herrenschmidt > --- > > Found while setting up some old ppc440 boxes for test/CI Applied, thanks.