From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH RFC 4/8] net: core: add recycle capabilities
 on skbs via page_pool API
Date: Fri, 07 Dec 2018 23:15:14 -0800 (PST)
Message-ID: <20181207.231514.1338299086653086987.davem@davemloft.net>
References: <154413868810.21735.572808840657728172.stgit@firesoul>
        <154413874729.21735.10644578158550468689.stgit@firesoul>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, toke@toke.dk, ard.biesheuvel@linaro.org,
        jasowang@redhat.com, ilias.apalodimas@linaro.org,
        bjorn.topel@intel.com, w@1wt.eu, saeedm@mellanox.com,
        mykyta.iziumtsev@gmail.com, borkmann@iogearbox.net,
        alexei.starovoitov@gmail.com, tariqt@mellanox.com
To: brouer@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:46296 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726084AbeLHHPQ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 8 Dec 2018 02:15:16 -0500
In-Reply-To: <154413874729.21735.10644578158550468689.stgit@firesoul>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Fri, 07 Dec 2018 00:25:47 +0100

> @@ -744,6 +745,10 @@ struct sk_buff {
>  				head_frag:1,
>  				xmit_more:1,
>  				pfmemalloc:1;
> +	/* TODO: Future idea, extend mem_info with __u8 flags, and
> +	 * move bits head_frag and pfmemalloc there.
> +	 */
> +	struct xdp_mem_info	mem_info;

This is 4 bytes right?

I guess I can live with this.

Please do some microbenchmarks to make sure this doesn't show any
obvious regressions.

Thanks.