From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 0/3] Packet based credit mode Date: Thu, 6 Dec 2018 20:27:06 -0700 Message-ID: <20181207032706.GA20134@ziepe.ca> References: <20181130112206.19870-1-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Doug Ledford , Leon Romanovsky , RDMA mailing list , Danit Goldberg , Majd Dibbiny , Saeed Mahameed , linux-netdev To: Leon Romanovsky Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:37597 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbeLGD1I (ORCPT ); Thu, 6 Dec 2018 22:27:08 -0500 Received: by mail-pl1-f194.google.com with SMTP id b5so1153804plr.4 for ; Thu, 06 Dec 2018 19:27:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181130112206.19870-1-leon@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Danit, > > Packet based credit mode is an alternative end-to-end credit mode for QPs > set during their creation. Credits are transported from the responder > to the requester to optimize the use of its receive resources. > In packet-based credit mode, credits are issued on a per packet basis. > > The advantage of this feature comes while sending large RDMA messages > through switches that are short in memory. > > The first commit exposes QP creation flag and the HCA capability. The > second commit adds support for a new DV QP creation flag. The last > commit report packet based credit mode capability via the MLX5DV device > capabilities. > > Thanks > > Danit Goldberg (3): > net/mlx5: Expose packet based credit mode > IB/mlx5: Add packet based credit mode support > IB/mlx5: Report packet based credit mode device capability This looks fine to me, can you update the shared branch please Thanks, Jason